Uploaded image for project: 'Kite SDK'
  1. Kite SDK
  2. KITE-406

kite-maven-plugin:package-app and deploy-app don't handle non-default values for applicationName

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.13.0
    • Fix Version/s: 0.14.1
    • Component/s: Maven Module
    • Labels:
      None

      Description

      kite-maven-plugin:package-app fails with IllegalArugmentException when applicationName is anything other than the default value.

      Caused by: java.lang.IllegalArgumentException: Parameter 'directory' is not a directory
      at org.apache.commons.io.FileUtils.listFiles(FileUtils.java:460)
      at org.apache.commons.io.FileUtils.listFiles(FileUtils.java:546)
      at org.kitesdk.maven.plugins.PackageAppMojo.execute(PackageAppMojo.java:140)
      at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101)
      ... 20 more

      See https://github.com/kite-sdk/kite/blob/release-0.13.0/kite-maven-plugin/src/main/java/org/kitesdk/maven/plugins/PackageAppMojo.java#L131

      "outputDir" refers to a directory that does not exist due to incorrect configuration of the maven-assembly-plugin. When changing the applicationName, the assemblyPlugin needs "finalName" = applicationName and "appendAssemblyId" = false such that it will create the output in the expected "outputDir".

      If this issue is corrected, deploy-app also fails with a non-default applicationName unless "localApplicationFile" is overridden. A trivial change can be made to correct that problem as well.

      I'm not sure how exactly you prefer to receive contributions, but I could provide a pull request with the changes to fix both of these issues.

        Attachments

          Activity

            People

            • Assignee:
              ben.roling Ben Roling
              Reporter:
              ben.roling Ben Roling
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: