Uploaded image for project: 'Hue (READ ONLY)'
  1. Hue (READ ONLY)
  2. HUE-2818

Stop ignoring migration errors in app_reg

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Incomplete
    • Affects Version/s: 3.8.0
    • Fix Version/s: None
    • Component/s: core.api
    • Labels:
      None

      Description

      It turns out that app_reg has been ignoring migration errors for a long time, which is probably why we saw some upgrades succeed even though some migrations failed to run. I've got a patch that fixes, this, but unfortunately this breaks our build. This is happening of commits like 11582cbd, which adds some migrations to Oozie, Beeswax, and etc that are required to run before some Desktop migrations. Unfortunatately though our build process runs all the desktop migrations before installing the apps. This results in errors like:

      ...
      Running migrations for desktop:
       ! Migration desktop:0007_auto__add_documentpermission__add_documenttag__add_document should not have been applied before oozie:0025_change_examples_path_format but was.
       ! Migration desktop:0007_auto__add_documentpermission__add_documenttag__add_document should not have been applied before pig:0001_initial but was.
       ! Migration desktop:0007_auto__add_documentpermission__add_documenttag__add_document should not have been applied before beeswax:0008_auto__add_field_queryhistory_query_type but was.
       ! Migration desktop:0007_auto__add_documentpermission__add_documenttag__add_document should not have been applied before oozie:0025_change_examples_path_format but was.
       ! Migration desktop:0007_auto__add_documentpermission__add_documenttag__add_document should not have been applied before pig:0001_initial but was.
       ! Migration desktop:0007_auto__add_documentpermission__add_documenttag__add_document should not have been applied before beeswax:0008_auto__add_field_queryhistory_query_type but was.
       ! Migration desktop:0007_auto__add_documentpermission__add_documenttag__add_document should not have been applied before oozie:0025_change_examples_path_format but was.
       ! Migration desktop:0007_auto__add_documentpermission__add_documenttag__add_document should not have been applied before pig:0001_initial but was.
       ! Migration desktop:0007_auto__add_documentpermission__add_documenttag__add_document should not have been applied before beeswax:0008_auto__add_field_queryhistory_query_type but was.
       ! Migration desktop:0007_auto__add_documentpermission__add_documenttag__add_document should not have been applied before oozie:0025_change_examples_path_format but was.
       ! Migration desktop:0007_auto__add_documentpermission__add_documenttag__add_document should not have been applied before pig:0001_initial but was.
       ! Migration desktop:0007_auto__add_documentpermission__add_documenttag__add_document should not have been applied before beeswax:0008_auto__add_field_queryhistory_query_type but was.
       ! Migration desktop:0007_auto__add_documentpermission__add_documenttag__add_document should not have been applied before oozie:0025_change_examples_path_format but was.
       ! Migration desktop:0007_auto__add_documentpermission__add_documenttag__add_document should not have been applied before pig:0001_initial but was.
       ! Migration desktop:0007_auto__add_documentpermission__add_documenttag__add_document should not have been applied before beeswax:0008_auto__add_field_queryhistory_query_type but was.
       ! Migration desktop:0007_auto__add_documentpermission__add_documenttag__add_document should not have been applied before oozie:0025_change_examples_path_format but was.
       ! Migration desktop:0007_auto__add_documentpermission__add_documenttag__add_document should not have been applied before pig:0001_initial but was.
       ! Migration desktop:0007_auto__add_documentpermission__add_documenttag__add_document should not have been applied before beeswax:0008_auto__add_field_queryhistory_query_type but was.
       ! Migration desktop:0007_auto__add_documentpermission__add_documenttag__add_document should not have been applied before oozie:0025_change_examples_path_format but was.
       ! Migration desktop:0007_auto__add_documentpermission__add_documenttag__add_document should not have been applied before pig:0001_initial but was.
       ! Migration desktop:0007_auto__add_documentpermission__add_documenttag__add_document should not have been applied before beeswax:0008_auto__add_field_queryhistory_query_type but was.
       ! Migration desktop:0007_auto__add_documentpermission__add_documenttag__add_document should not have been applied before oozie:0025_change_examples_path_format but was.
       ! Migration desktop:0007_auto__add_documentpermission__add_documenttag__add_document should not have been applied before pig:0001_initial but was.
       ! Migration desktop:0007_auto__add_documentpermission__add_documenttag__add_document should not have been applied before beeswax:0008_auto__add_field_queryhistory_query_type but was.
      ...
      

      But because we were ignoring these errors, we never noticed it.

      Two ideas to fix it. In order to fix this, we need to make sure that Desktop migrations don't implicitly or explicitly depend on any other migrations.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              erickt Erick Tryzelaar
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: