Uploaded image for project: 'Kite SDK (READ-ONLY)'
  1. Kite SDK (READ-ONLY)
  2. KITE-908

Fix View#delete for unpartitioned datasets

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.17.1
    • Fix Version/s: 1.0.0
    • Component/s: Data Module
    • Labels:
      None

      Description

      View#delete doesn't work for unpartitioned datasets. This is because the alignedWithParititons check requires a partition strategy. But it should return true for an unpartitioned dataset if the constraint set is empty.

      blue@work:~/tmp$ kite-dataset -v delete view:file:/home/blue/tmp/datasets/ml/movies
      Unknown error
      java.lang.UnsupportedOperationException: Cannot cleanly delete view: FileSystemView{dataset=FileSystemDataset{name=movies, descriptor=DatasetDescriptor{format=Format{name=avro}, schema={"type":"record","name":"Movie","namespace":"org.kitesdk.examples.movies","doc":"Schema generated by Kite","fields":[{"name":"id","type":"long","doc":"Movie ID"},{"name":"title","type":"string","doc":"Movie title, like 'Toy Story (1995)'"},{"name":"release_date","type":"string","doc":"Release date, like '01-Jan-1995'"},{"name":"imdb_url","type":["null","string"],"doc":"URL to IMDB entry, like 'http://us.imdb.com/M/title-exact?title(year)'","default":null}]}, location=file:/home/blue/tmp/datasets/ml/movies, properties={}, partitionStrategy=null, compressionType=CompressionType{name=snappy}}, directory=file:/home/blue/tmp/datasets/ml/movies, dataDirectory=file:/home/blue/tmp/datasets/ml/movies, partitionKey=null}, constraints=Constraints{{}}}
              at org.kitesdk.data.spi.filesystem.FileSystemView.deleteAll(FileSystemView.java:105)
              at org.kitesdk.cli.commands.DeleteCommand.run(DeleteCommand.java:55)
              at org.kitesdk.cli.Main.run(Main.java:178)
              at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
              at org.kitesdk.cli.Main.main(Main.java:256)
      

        Attachments

          Activity

            People

            • Assignee:
              blue Ryan Blue
              Reporter:
              blue Ryan Blue
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: